6 commits

Author	SHA1	Message	Date
Googler	af926372c5	Replace toolchain_features with known_features and enabled_features. ... BEGIN_PUBLIC Replace toolchain_features with known_features and enabled_features. This should allow for the deprecation of action_type_config, as `implies` there is no longer required. END_PUBLIC PiperOrigin-RevId: 658620044 Change-Id: Idda9bd77edad1be1fd26d5a655e3b9084d38bca8	2024-08-01 19:14:33 -07:00
Googler	f97190f039	Remove feature requirements from tools. ... BEGIN_PUBLIC Remove feature requirements from tools. It's such a niche use case, adds a fair amount of complexity, and there are multiple alternatives available: * Now that we're using rule based things, you should just be able to add a bazel flag and select on it in your tool definition. * If you really want precisely that behaviour, you can make your feature add "--use-foo-tool" to the args, and make your tool a wrapper tool that reads the command-line argument, and if provided, invokes a different tool. END_PUBLIC PiperOrigin-RevId: 657383729 Change-Id: Idb4f3ad66dc92d48ef81a1e8875bf6d3ba215aa4	2024-07-29 17:37:10 -07:00
Googler	ac3f19bac7	Remove support for args from action_type_config. ... BEGIN_PUBLIC Remove support for args from action_type_config. Args in individual action type configs result in redundant configuration, where both the cc_args and the cc_action_type_config control which actions they're enabled for. Instead of: ``` cc_args(name = "compile_args", action_types = [":c_compile", ":cpp_compile]) cc_action_type_config(name = "c_compile_config", actions = [":c_compile"], args = [":compile_args"]) cc_action_type_config(name = "cpp_compile_config", actions = [":cpp_compile"], args = [":compile_args"]) cc_toolchain(action_type_configs = [":c_compile_config", ":cpp_compile_config"]) ``` We should force users to write the following: ``` cc_args(name = "compile_args", action_types = [":c_compile", ":cpp_compile]) cc_action_type_config(name = "c_compile_config", actions = [":c_compile"]) cc_action_type_config(name = "cpp_compile_config", actions = [":cpp_compile"]) cc_toolchain(action_type_configs = [":c_compile_config", ":cpp_compile_config"], args = [":compile_args"]) ``` END_PUBLIC PiperOrigin-RevId: 642432029 Change-Id: I1aa7c1752f4d915d8c84c17a06314ae9ad2c69f0	2024-06-11 16:35:03 -07:00
Googler	aa19278bbd	Rename ExpandArgs to NestedArgs ... After discussion with @amontanez in unknown commit, we decided that NestedArgs was a more appropriate name. BEGIN_PUBLIC Rename ExpandArgs to NestedArgs END_PUBLIC PiperOrigin-RevId: 617085672 Change-Id: I1d7190cac79f8fa953d23be7d0db3b028a84cf30	2024-03-19 01:09:56 -07:00
Googler	bbb0615a87	Refactor AddArgsInfo into ExpandArgsInfo ... BEGIN_PUBLIC Refactor AddArgsInfo into ExpandArgsInfo This allows us to create a similar mechanism to the current toolchain, while maintaining type safety. END_PUBLIC PiperOrigin-RevId: 615939056 Change-Id: I9b6763150194f8a76dfd8da730a3e2d45accbe20	2024-03-14 16:28:07 -07:00
Googler	de4aaa6472	Allow cc_toolchain_info rule to be used as a parameter to pass into native.cc_toolchain(config = ...) ... BEGIN_PUBLIC Allow cc_toolchain_info rule to be used as a parameter to pass into native.cc_toolchain(config = ...) END_PUBLIC PiperOrigin-RevId: 613000772 Change-Id: I8348e2cbb4aa7d0a523341dcaf1e2c2bc647f640	2024-03-05 16:04:53 -08:00