bazel
/
rules_cc
mirror of https://github.com/bazelbuild/rules_cc
2
0
Fork 0
Code Issues Releases Activity

Address more comments

This commit is contained in:
Armando Montanez 2024-10-03 19:46:02 -07:00
parent 4ac204f4ed
commit e8989401d5
6 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/rule_based_toolchain/BUILD.bazel
View File

@ -14,8 +14,6 @@
load("@rules_cc//cc:defs.bzl", "cc_test")
package(default_visibility = ["//visibility:public"])
licenses(["notice"])
cc_test(

3
examples/rule_based_toolchain/dynamic_answer/BUILD.bazel
View File

@ -14,8 +14,6 @@
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_shared_library")
package(default_visibility = ["//visibility:public"])
licenses(["notice"])
cc_library(
@ -42,5 +40,6 @@ cc_shared_library(
cc_library(
name = "dynamic_answer",
srcs = [":shared_library"],
visibility = ["//visibility:public"],
deps = [":headers"],
)

3
examples/rule_based_toolchain/static_answer/BUILD.bazel
View File

@ -14,8 +14,6 @@
load("@rules_cc//cc:defs.bzl", "cc_library")
package(default_visibility = ["//visibility:public"])
licenses(["notice"])
cc_library(
@ -31,4 +29,5 @@ cc_library(
alias(
name = "static_answer",
actual = ":answer",
visibility = ["//visibility:public"],
)

5
examples/rule_based_toolchain/toolchain/args/BUILD.bazel
View File

@ -15,8 +15,6 @@
load("@rules_cc//cc/toolchains:args.bzl", "cc_args")
load("@rules_cc//cc/toolchains/args:sysroot.bzl", "cc_sysroot")
package(default_visibility = ["//visibility:public"])
cc_sysroot(
name = "linux_sysroot",
data = [
@ -25,6 +23,7 @@ cc_sysroot(
"@linux_sysroot//:usr-include-x86_64-linux-gnu",
],
sysroot = "@linux_sysroot//:root",
visibility = ["//visibility:public"],
)
cc_args(
@ -39,6 +38,7 @@ cc_args(
"-Wextra",
"-Wpedantic",
],
visibility = ["//visibility:public"],
)
cc_args(
@ -48,4 +48,5 @@ cc_args(
"@rules_cc//cc/toolchains/actions:cpp_compile_actions",
],
args = ["-no-canonical-prefixes"],
visibility = ["//visibility:public"],
)

5
examples/rule_based_toolchain/toolchain/clang.BUILD
View File

@ -78,5 +78,8 @@ filegroup(
# binary doesn't exist.
filegroup(
name = "multicall_support_files",
srcs = glob(["bin/llvm"]),
srcs = glob(
["bin/llvm"],
allow_empty = True,
),
)

3
examples/rule_based_toolchain/toolchain/tools/BUILD.bazel
View File

@ -15,8 +15,6 @@
load("@rules_cc//cc/toolchains:tool.bzl", "cc_tool")
load("@rules_cc//cc/toolchains:tool_map.bzl", "cc_tool_map")
package(default_visibility = ["//visibility:public"])
licenses(["notice"])
# This `select` happens under the target configuration. For macOS,
@ -28,6 +26,7 @@ alias(
"@platforms//os:macos": ":macos_tools",
"//conditions:default": ":default_tools",
}),
visibility = ["//visibility:public"],
)
COMMON_TOOLS = {