From 2c9c93bc072bc969003b0aeebd16ae213def6c5f Mon Sep 17 00:00:00 2001 From: Marcel Hlopko Date: Wed, 9 Oct 2019 09:49:37 +0200 Subject: [PATCH 1/2] Update googletest to 1.10.x --- WORKSPACE | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 3aa393c..5503451 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -25,14 +25,12 @@ rules_cc_internal_deps() load("//:internal_setup.bzl", "rules_cc_internal_setup") rules_cc_internal_setup() -# We're pinning to a commit because this project does not have a recent release. -# Nothing special about this commit, though. http_archive( name = "com_google_googletest", - sha256 = "0fb00ff413f6b9b80ccee44a374ca7a18af7315aea72a43c62f2acd1ca74e9b5", - strip_prefix = "googletest-f13bbe2992d188e834339abe6f715b2b2f840a77", + sha256 = "4d7cd95cdb0ef420eed163696a906cccd70964801ea611b2020f31177432c27d", + strip_prefix = "googletest-1.10.x", urls = [ - "https://mirror.bazel.build/github.com/google/googletest/archive/f13bbe2992d188e834339abe6f715b2b2f840a77.tar.gz", - "https://github.com/google/googletest/archive/f13bbe2992d188e834339abe6f715b2b2f840a77.tar.gz", + "https://mirror.bazel.build/github.com/google/googletest/archive/v1.10.x.tar.gz", + "https://github.com/google/googletest/archive/v1.10.x.tar.gz", ], ) From 54c783c4d9a0a415c3082a96ad79f0a7a1057124 Mon Sep 17 00:00:00 2001 From: Marcel Hlopko Date: Wed, 9 Oct 2019 15:18:06 +0200 Subject: [PATCH 2/2] Actually, lets depend on the release archive, not the branch --- WORKSPACE | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 5503451..365eb83 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -27,10 +27,10 @@ rules_cc_internal_setup() http_archive( name = "com_google_googletest", - sha256 = "4d7cd95cdb0ef420eed163696a906cccd70964801ea611b2020f31177432c27d", - strip_prefix = "googletest-1.10.x", + sha256 = "9dc9157a9a1551ec7a7e43daea9a694a0bb5fb8bec81235d8a1e6ef64c716dcb", + strip_prefix = "googletest-release-1.10.0", urls = [ - "https://mirror.bazel.build/github.com/google/googletest/archive/v1.10.x.tar.gz", - "https://github.com/google/googletest/archive/v1.10.x.tar.gz", + "https://mirror.bazel.build/github.com/google/googletest/archive/release-1.10.0.tar.gz", + "https://github.com/google/googletest/archive/release-1.10.0.tar.gz", ], )