bazel
/
platforms
mirror of https://github.com/bazelbuild/platforms
2
0
Fork 0
Code Issues Releases Activity

Add Apple visionos. 

I'm not really satisified with this PR. The number of Apple specific platforms has grown to the point where we may want to refactor them. The question I would focus on is how various toolchain matches and select clauses go.

Do we see things like:

```
foo = select({
  ".../os:linux": A,
  ".../os:windows": B,
  ".../os:macos": C,
  ".../os:watchos": C,
  ".../os:visionos": C,
})
```

Where C is the same for all the apple platforms?

Or, do we see real distinctions across the various per-device OSes. Or a mix of both?
And, do we see the fanout of the Apple OSes done with a select_or wrapper, so users end up seeing the simple selection of just apple, linux, or windows, but we buried complexity elsewhere?
This commit is contained in:
Tony Aiuto 2023-06-26 10:58:38 -04:00
parent 7815f135e3
commit ba032f8c98
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
os/BUILD
View File

@ -82,6 +82,11 @@ constraint_value(
constraint_setting = ":os",
)
constraint_value(
name = "visionos",
constraint_setting = ":os",
)
constraint_value(
name = "qnx",
constraint_setting = ":os",