bazel
/
bazel-skylib
mirror of https://github.com/bazelbuild/bazel-skylib
2
0
Fork 0
Code Issues Releases Activity

diff_test: add ability for caller to specify a message printed on fai… (#307) 

Useful for the use case of a pair of .test and .update targets for checked-in golden files
This commit is contained in:
Alex Eagle 2021-08-18 08:23:43 -07:00 committed by GitHub
parent 0c57e74606
commit df3c9e2735
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rules/diff_test.bzl
View File

@ -58,7 +58,7 @@ if "!RF2!" equ "" (
fc.exe 2>NUL 1>NUL /B "!RF1!" "!RF2!" fc.exe 2>NUL 1>NUL /B "!RF1!" "!RF2!"
if %ERRORLEVEL% neq 0 ( if %ERRORLEVEL% neq 0 (
if %ERRORLEVEL% equ 1 ( if %ERRORLEVEL% equ 1 (
echo>&2 FAIL: files "{file1}" and "{file2}" differ echo>&2 FAIL: files "{file1}" and "{file2}" differ. {fail_msg}
exit /b 1 exit /b 1
) else ( ) else (
fc.exe /B "!RF1!" "!RF2!" fc.exe /B "!RF1!" "!RF2!"
@ -66,6 +66,7 @@ if %ERRORLEVEL% neq 0 (
) )
) )
""".format( """.format(
fail_msg = ctx.attr.failure_message,
file1 = _runfiles_path(ctx.file.file1), file1 = _runfiles_path(ctx.file.file1),
file2 = _runfiles_path(ctx.file.file2), file2 = _runfiles_path(ctx.file.file2),
), ),
@ -95,10 +96,11 @@ else
exit 1 exit 1
fi fi
if ! diff "$RF1" "$RF2"; then if ! diff "$RF1" "$RF2"; then
echo >&2 "FAIL: files \"{file1}\" and \"{file2}\" differ" echo >&2 "FAIL: files \"{file1}\" and \"{file2}\" differ. {fail_msg}"
exit 1 exit 1
fi fi
""".format( """.format(
fail_msg = ctx.attr.failure_message,
file1 = _runfiles_path(ctx.file.file1), file1 = _runfiles_path(ctx.file.file1),
file2 = _runfiles_path(ctx.file.file2), file2 = _runfiles_path(ctx.file.file2),
), ),
@ -112,6 +114,7 @@ fi
_diff_test = rule( _diff_test = rule(
attrs = { attrs = {
"failure_message": attr.string(),
"file1": attr.label( "file1": attr.label(
allow_single_file = True, allow_single_file = True,
mandatory = True, mandatory = True,