bazel
/
bazel-skylib
mirror of https://github.com/bazelbuild/bazel-skylib
2
0
Fork 0
Code Issues Releases Activity

Prettify failure message of asserts.set_equals. (#263) 

Before, when comparing large sets, the message dumped the whole set. Now it additionally prints missing and unexpected elements.
This commit is contained in:
Ivo List 2020-08-11 14:52:32 +02:00 committed by GitHub
parent 16de038c48
commit dc080e9516
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/unittest.bzl
View File

@ -410,7 +410,13 @@ def _assert_set_equals(env, expected, actual, msg = None):
If omitted, a default will be used. If omitted, a default will be used.
""" """
if not new_sets.is_equal(expected, actual): if not new_sets.is_equal(expected, actual):
expectation_msg = "Expected %r, but got %r" % (expected, actual) missing = new_sets.difference(expected, actual)
unexpected = new_sets.difference(actual, expected)
expectation_msg = "Expected %s, but got %s" % (new_sets.str(expected), new_sets.str(actual))
if new_sets.length(missing) > 0:
expectation_msg += ", missing are %s" % (new_sets.str(missing))
if new_sets.length(unexpected) > 0:
expectation_msg += ", unexpected are %s" % (new_sets.str(unexpected))
if msg: if msg:
full_msg = "%s (%s)" % (msg, expectation_msg) full_msg = "%s (%s)" % (msg, expectation_msg)
else: else: