bazel
/
bazel-skylib
mirror of https://github.com/bazelbuild/bazel-skylib
2
0
Fork 0
Code Issues Releases Activity

Remove --experimental_build_setting_api usage (#249) 

* Remove --experimental_build_setting_api usage

Deprecating this flag so removing all usage.

* One more rm

* fix ,

* Revert  semantics flags change
This commit is contained in:
Julie 2020-06-24 11:31:57 -04:00 committed by GitHub
parent ec2170289f
commit b10f2cb0fc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/common_settings_test.sh
View File

@ -133,7 +133,7 @@ function test_can_set_flags() {
local -r pkg="${FUNCNAME[0]}" local -r pkg="${FUNCNAME[0]}"
create_volcano_pkg "$pkg" create_volcano_pkg "$pkg"
bazel build volcano:mt-st-helens --experimental_build_setting_api --//volcano:height-flag=8366 \ bazel build volcano:mt-st-helens --//volcano:height-flag=8366 \
--//volcano:active-flag=False --//volcano:namer-flag=puyallup-tribe \ --//volcano:active-flag=False --//volcano:namer-flag=puyallup-tribe \
--//volcano:nicknames-flag=volcano-mc-volcanoface \ --//volcano:nicknames-flag=volcano-mc-volcanoface \
>"$TEST_log" 2>&1 || fail "Expected test to pass" >"$TEST_log" 2>&1 || fail "Expected test to pass"
@ -148,7 +148,7 @@ function test_cannot_set_settings() {
local -r pkg="${FUNCNAME[0]}" local -r pkg="${FUNCNAME[0]}"
create_volcano_pkg "$pkg" create_volcano_pkg "$pkg"
bazel build volcano:mt-st-helens --experimental_build_setting_api --//volcano:height-setting=8366 \ bazel build volcano:mt-st-helens --//volcano:height-setting=8366 \
>"$TEST_log" 2>&1 && fail "Expected test to fail" || true >"$TEST_log" 2>&1 && fail "Expected test to fail" || true
expect_log "Unrecognized option: //volcano:height-setting" expect_log "Unrecognized option: //volcano:height-setting"
@ -158,7 +158,7 @@ function test_not_allowed_value() {
local -r pkg="${FUNCNAME[0]}" local -r pkg="${FUNCNAME[0]}"
create_volcano_pkg "$pkg" create_volcano_pkg "$pkg"
bazel build volcano:mt-st-helens --experimental_build_setting_api --//volcano:namer-flag=me \ bazel build volcano:mt-st-helens --//volcano:namer-flag=me \
>"$TEST_log" 2>&1 && fail "Expected test to fail" || true >"$TEST_log" 2>&1 && fail "Expected test to fail" || true
expect_log "Error setting //volcano:namer-flag: invalid value 'me'. Allowed values are" expect_log "Error setting //volcano:namer-flag: invalid value 'me'. Allowed values are"