Remove unused, empty //rules:bins filegroup, allowing us to simplify distribution/BUILD (#359)

//rules:bins has not been used since 14f17ae7f7

Alternative to https://github.com/bazelbuild/bazel-skylib/pull/358
This commit is contained in:
Alexandre Rostovtsev 2022-03-10 07:41:11 -05:00 committed by GitHub
parent 5bffd04256
commit 898cd6ddff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 39 deletions

7
BUILD
View File

@ -75,10 +75,3 @@ filegroup(
"//toolchains/unittest:distribution", "//toolchains/unittest:distribution",
] + glob(["*.bzl"]), ] + glob(["*.bzl"]),
) )
filegroup(
name = "bins",
srcs = [
"//rules:bins",
],
)

View File

@ -6,37 +6,15 @@ package(
default_visibility = ["//visibility:private"], default_visibility = ["//visibility:private"],
) )
pkg_tar(
name = "srcs",
srcs = ["//:distribution"],
mode = "0444",
# Make it owned by root so it does not have the uid of the CI robot.
owner = "0.0",
package_dir = "",
strip_prefix = ".",
)
pkg_tar(
name = "bins",
srcs = ["//:bins"],
mode = "0555",
# Make it owned by root so it does not have the uid of the CI robot.
owner = "0.0",
package_dir = "",
strip_prefix = ".",
)
# Build the artifact to put on the github release page. # Build the artifact to put on the github release page.
pkg_tar( pkg_tar(
name = "bazel-skylib-%s" % version, name = "bazel-skylib-%s" % version,
srcs = ["//:distribution"],
extension = "tar.gz", extension = "tar.gz",
mode = "0644",
# Make it owned by root so it does not have the uid of the CI robot. # Make it owned by root so it does not have the uid of the CI robot.
owner = "0.0", owner = "0.0",
strip_prefix = ".", strip_prefix = ".",
deps = [
":bins.tar",
":srcs.tar",
],
) )
print_rel_notes( print_rel_notes(

View File

@ -68,14 +68,6 @@ filegroup(
], ],
) )
filegroup(
name = "bins",
srcs = glob(["*.sh"]),
visibility = [
"//:__pkg__",
],
)
# export bzl files for the documentation # export bzl files for the documentation
exports_files( exports_files(
glob(["*.bzl"]), glob(["*.bzl"]),