mirror of
https://github.com/bazelbuild/bazel-skylib
synced 2024-11-26 04:30:24 +00:00
resolve dkelmer review comments
This commit is contained in:
parent
dddf3517a8
commit
70bfaca2a2
|
@ -407,7 +407,7 @@ def _expect_failure(env, expected_failure_msg = ""):
|
|||
actual_errors += cause.message + "\n"
|
||||
if actual_errors.find(expected_failure_msg) < 0:
|
||||
expectation_msg = "Expected errors to contain '%s' but did not. " % expected_failure_msg
|
||||
expectation_msg += "Actual error:%s" % actual_errors
|
||||
expectation_msg += "Actual errors:%s" % actual_errors
|
||||
_fail(env, expectation_msg)
|
||||
else:
|
||||
_fail(env, "Expected failure of target_under_test, but found success")
|
||||
|
|
|
@ -3,7 +3,7 @@
|
|||
load("//lib:unittest.bzl", "analysistest", "asserts", "unittest")
|
||||
|
||||
###################################
|
||||
####### fail_basic_test ########
|
||||
####### fail_basic_test ###########
|
||||
###################################
|
||||
def _basic_failing_test(ctx):
|
||||
"""Unit tests for a basic library verification test that fails."""
|
||||
|
|
Loading…
Reference in a new issue