From 3b666f525dfc645eea2bc4832796f8d6a07a997a Mon Sep 17 00:00:00 2001 From: Andrew Z Allen Date: Fri, 19 Jun 2020 11:49:52 -0600 Subject: [PATCH] Address lint errors (#254) --- lib/unittest.bzl | 3 ++- tests/build_test_tests.bzl | 1 + tests/selects_tests.bzl | 1 + tests/unittest_tests.bzl | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/unittest.bzl b/lib/unittest.bzl index 2b9d267..a6d981c 100644 --- a/lib/unittest.bzl +++ b/lib/unittest.bzl @@ -23,6 +23,7 @@ load(":new_sets.bzl", new_sets = "sets") load(":types.bzl", "types") # The following function should only be called from WORKSPACE files and workspace macros. +# buildifier: disable=unnamed-macro def register_unittest_toolchains(): """Registers the toolchains for unittest users.""" native.register_toolchains( @@ -282,7 +283,7 @@ def _begin(ctx): test. Args: - ctx: The Skylark context. Pass the implementation function's `ctx` argument + ctx: The Starlark context. Pass the implementation function's `ctx` argument in verbatim. Returns: diff --git a/tests/build_test_tests.bzl b/tests/build_test_tests.bzl index 3b2832b..5bcbbd3 100644 --- a/tests/build_test_tests.bzl +++ b/tests/build_test_tests.bzl @@ -17,6 +17,7 @@ load("//rules:build_test.bzl", "build_test") load("@rules_cc//cc:defs.bzl", "cc_library") +# buildifier: disable=unnamed-macro def build_test_test_suite(): # Since the rules doesn't do anything really, it just makes some targets # to get Bazel to build other targets via a `bazel test`, just make some diff --git a/tests/selects_tests.bzl b/tests/selects_tests.bzl index ceefa03..28f3ac4 100644 --- a/tests/selects_tests.bzl +++ b/tests/selects_tests.bzl @@ -607,6 +607,7 @@ def _always_true_match_any_test(): ################################################### +# buildifier: disable=unnamed-macro def selects_test_suite(): """Creates the test targets and test suite for selects.bzl tests.""" unittest.suite( diff --git a/tests/unittest_tests.bzl b/tests/unittest_tests.bzl index ed1c599..3ac98f0 100644 --- a/tests/unittest_tests.bzl +++ b/tests/unittest_tests.bzl @@ -223,6 +223,7 @@ inspect_output_dirs_test = analysistest.make( ######################################### +# buildifier: disable=unnamed-macro def unittest_passing_tests_suite(): """Creates the test targets and test suite for passing unittest.bzl tests.