From 1e1c324391d81b3c768e4a11e50106929953f348 Mon Sep 17 00:00:00 2001
From: Alexandre Rostovtsev <arostovtsev@google.com>
Date: Thu, 10 Feb 2022 14:50:56 -0500
Subject: [PATCH] Fix linter warnings with new buildifier version. (#349)

---
 rules/analysis_test.bzl  | 2 +-
 tests/selects_tests.bzl  | 3 ---
 tests/unittest_tests.bzl | 5 +++--
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/rules/analysis_test.bzl b/rules/analysis_test.bzl
index 46d32dd..3420d48 100644
--- a/rules/analysis_test.bzl
+++ b/rules/analysis_test.bzl
@@ -16,7 +16,7 @@
 
 def _analysis_test_impl(ctx):
     """Implementation function for analysis_test. """
-    _ignore = [ctx]
+    _ignore = [ctx]  # @unused
     return [AnalysisTestResultInfo(
         success = True,
         message = "All targets succeeded analysis",
diff --git a/tests/selects_tests.bzl b/tests/selects_tests.bzl
index 7a980e6..a7697f2 100644
--- a/tests/selects_tests.bzl
+++ b/tests/selects_tests.bzl
@@ -156,9 +156,6 @@ def _expect_doesnt_match(ctx):
     asserts.equals(env, False, attrval)
     return analysistest.end(env)
 
-def _config_setting_group_test(name, config_settings):
-    return analysistest.make()
-
 ###################################################
 # and_config_setting_group_matches_test
 ###################################################
diff --git a/tests/unittest_tests.bzl b/tests/unittest_tests.bzl
index 5541d74..47dcee0 100644
--- a/tests/unittest_tests.bzl
+++ b/tests/unittest_tests.bzl
@@ -122,7 +122,7 @@ def _failure_testing_test(ctx):
     return analysistest.end(env)
 
 def _failure_testing_fake_rule(ctx):
-    _ignore = [ctx]
+    _ignore = [ctx]  # @unused
     fail("This rule should never work")
 
 failure_testing_fake_rule = rule(
@@ -146,7 +146,7 @@ def _fail_unexpected_passing_test(ctx):
     return analysistest.end(env)
 
 def _fail_unexpected_passing_fake_rule(ctx):
-    _ignore = [ctx]
+    _ignore = [ctx]  # @unused
     return []
 
 fail_unexpected_passing_fake_rule = rule(
@@ -227,6 +227,7 @@ _AddedByAspectInfo = provider(
 )
 
 def _example_aspect_impl(target, ctx):
+    _ignore = [target, ctx]  # @unused
     return [
         _AddedByAspectInfo(value = "attached by aspect"),
     ]