From 15007f24e2bb393262bc0ec23039ce88ef2ea829 Mon Sep 17 00:00:00 2001 From: Chris Sauer Date: Wed, 24 Apr 2024 11:23:39 -0700 Subject: [PATCH] Remove outdated rules_cc dependency (#476) Fixes #475 --- MODULE.bazel | 1 - WORKSPACE | 10 ---------- tests/build_test_tests.bzl | 3 +-- tests/native_binary/BUILD | 1 - tests/run_binary/BUILD | 1 - 5 files changed, 1 insertion(+), 15 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index 298974a..1d8de47 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -17,7 +17,6 @@ bazel_dep(name = "platforms", version = "0.0.4") # Build-only / test-only dependencies bazel_dep(name = "stardoc", version = "0.5.6", dev_dependency = True, repo_name = "io_bazel_stardoc") bazel_dep(name = "rules_pkg", version = "0.9.1", dev_dependency = True) -bazel_dep(name = "rules_cc", version = "0.0.2", dev_dependency = True) # Needed for bazelci and for building distribution tarballs. # If using an unreleased version of bazel_skylib via git_override, apply diff --git a/WORKSPACE b/WORKSPACE index de97069..b51bb9b 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -52,16 +52,6 @@ load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies") rules_pkg_dependencies() -maybe( - name = "rules_cc", - repo_rule = http_archive, - sha256 = "4dccbfd22c0def164c8f47458bd50e0c7148f3d92002cdb459c2a96a68498241", - urls = [ - "https://mirror.bazel.build/github.com/bazelbuild/rules_cc/releases/download/0.0.1/rules_cc-0.0.1.tar.gz", - "https://github.com/bazelbuild/rules_cc/releases/download/0.0.1/rules_cc-0.0.1.tar.gz", - ], -) - load("//lib:unittest.bzl", "register_unittest_toolchains") register_unittest_toolchains() diff --git a/tests/build_test_tests.bzl b/tests/build_test_tests.bzl index 4d3dfb6..9fbe89b 100644 --- a/tests/build_test_tests.bzl +++ b/tests/build_test_tests.bzl @@ -14,7 +14,6 @@ """Unit tests for build_test.bzl.""" -load("@rules_cc//cc:defs.bzl", "cc_library") load("//rules:build_test.bzl", "build_test") # buildifier: disable=unnamed-macro @@ -31,7 +30,7 @@ def build_test_test_suite(): ) # Use it in a non-test target - cc_library( + native.cc_library( name = "build_test__build_target", srcs = [":build_test__make_src"], ) diff --git a/tests/native_binary/BUILD b/tests/native_binary/BUILD index 997270f..d60b78a 100644 --- a/tests/native_binary/BUILD +++ b/tests/native_binary/BUILD @@ -1,4 +1,3 @@ -load("@rules_cc//cc:defs.bzl", "cc_binary") load("//rules:copy_file.bzl", "copy_file") load("//rules:native_binary.bzl", "native_binary", "native_test") diff --git a/tests/run_binary/BUILD b/tests/run_binary/BUILD index 259c84a..0b02087 100644 --- a/tests/run_binary/BUILD +++ b/tests/run_binary/BUILD @@ -1,4 +1,3 @@ -load("@rules_cc//cc:defs.bzl", "cc_binary") load("//rules:diff_test.bzl", "diff_test") load("//rules:run_binary.bzl", "run_binary") load("//rules:write_file.bzl", "write_file")