From 10851c2c5bd528a518af23b2a23f2efe4427f139 Mon Sep 17 00:00:00 2001
From: Julie <30670028+juliexxia@users.noreply.github.com>
Date: Wed, 3 Jul 2019 14:42:40 -0400
Subject: [PATCH] Give BuildSettingInfo's value field a description (#167)

---
 docs/common_settings_doc.md | 2 +-
 rules/common_settings.bzl   | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/docs/common_settings_doc.md b/docs/common_settings_doc.md
index 1ab03a3..676f070 100755
--- a/docs/common_settings_doc.md
+++ b/docs/common_settings_doc.md
@@ -287,7 +287,7 @@ A singleton provider that contains the raw value of a build setting
     <tr id="BuildSettingInfo-value">
       <td><code>value</code></td>
       <td>
-        <p>(Undocumented)</p>
+        <p>The value of the build setting in the current configuration. This value may come from the command line or an upstream transition, or else it will be the build setting's default.</p>
       </td>
     </tr>
   </tbody>
diff --git a/rules/common_settings.bzl b/rules/common_settings.bzl
index d10e1de..9dca70e 100644
--- a/rules/common_settings.bzl
+++ b/rules/common_settings.bzl
@@ -23,7 +23,11 @@ https://docs.bazel.build/versions/master/skylark/config.html#user-defined-build-
 
 BuildSettingInfo = provider(
     doc = "A singleton provider that contains the raw value of a build setting",
-    fields = ["value"]
+    fields = {
+        "value": "The value of the build setting in the current configuration. "
+        + "This value may come from the command line or an upstream transition, "
+        + "or else it will be the build setting's default."
+    }
 )
 
 def _impl(ctx):