Jason Bedard
475015bee0
refactor: give internal impl methods meaningful names ( #252 )
2022-09-20 15:23:56 -07:00
Greg Magolan
8e230b0721
feat: add bazel_version value to host_repo repository rule ( #246 )
2022-09-16 11:51:48 -07:00
Greg Magolan
65e852f774
fix: don't generate @aspect_bazel_lib_local_config_platform repository as it is a leaky abstraction for rule consumers and not just rule authors ( #243 )
2022-09-13 21:58:08 -07:00
Greg Magolan
be5c9d06bc
fix: fix bzl_library breakage created with load from @local_config_platform in copy rules ( #242 )
2022-09-13 20:37:24 -07:00
Greg Magolan
bbfb74c8e6
fix: fix host platform detection on all copy actions which always run locally ( #241 )
2022-09-12 20:45:48 -07:00
Jason Bedard
803dbf815e
copy_to_directory performance improvements ( #236 )
...
* reduce use of depset.to_list()
* avoid copying arrays when invoking copy_file
* fixup! reduce use of depset.to_list()
* fixup! reduce use of depset.to_list()
2022-09-12 18:01:25 -07:00
John Firebaugh
21216126b6
Add TODO comment in the windows implementation
2022-09-07 13:53:08 -07:00
John Firebaugh
77137f4020
Add JUnit XML output for diff_test
2022-09-07 13:53:08 -07:00
David Zbarsky
5edb10a0d8
Cleanup diff_test and copy_file implementations
2022-08-31 12:12:47 -07:00
Alex Eagle
b5653b6037
fix: TARGET make variable expansion: no extra leading @
...
Part of https://github.com/aspect-build/rules_js/issues/406
2022-08-29 07:45:00 -07:00
Greg Magolan
9efedb72c0
fix: handle the ** root_path case correctly in copy_to_directory
2022-08-25 21:25:13 -07:00
Greg Magolan
cbec12b286
chore: remote out-of-date reference to DefaultOutputPathInfo in write_source_files error message
2022-08-25 20:25:21 -07:00
Alex Eagle
f688d17cfb
feat: jq supports stamping
...
Fixes #223
2022-08-22 12:39:54 -07:00
Alex Eagle
896ee0c1f0
chore: set test timeouts to short
...
I recently enabled --test_verbose_timeout_warnings and that caused a bunch of warnings in our build.
This fixes it, and adds a utility for us or others to make test-wrapping macros that set to short by default.
2022-08-20 13:58:43 -07:00
Derek Cormier
889e736476
fix: fix a bug where the same file couldn't be copied to the same output
...
dir twice on Windows
2022-08-20 11:31:56 -07:00
Alex Eagle
15ec78eb73
ci: enable engflow RBE for github actions
2022-08-19 08:42:00 -07:00
Greg Magolan
3e20e6c0b1
fix: fix issue in copy_to_directory where root_path is the full path of a directory input
2022-08-18 21:14:12 -07:00
Twan Koolen
e446a3d8e7
Add failing test case demonstrating issue with root_paths in the presence of globs in dependencies.
2022-08-18 21:14:12 -07:00
Derek Cormier
c1e7aa1181
fix: fix a bug where multiple files were not written at the root package
2022-08-16 11:20:55 -07:00
Greg Magolan
c867e37856
fix: fix make var expansion in expand_template ( #213 )
2022-08-11 19:30:45 -07:00
Greg Magolan
3caff577b9
fix: handle copy_to_directory '.' and './**' special patterns correctly when in the root package ( #212 )
2022-08-11 16:25:51 -07:00
Alex Eagle
20d759f669
feat: add utility for asserting that a file contains a string
...
Useful for basic smoke tests of bazel outputs
2022-08-04 18:02:29 -07:00
Greg Magolan
165d7dafdb
chore: normalize src and outputs paths in copy_to_directory ( #206 )
2022-08-01 13:14:18 -07:00
Greg Magolan
06d54eef4c
fix: improve handling of duplicate files in copy_to_directory ( #205 )
2022-08-01 09:56:52 -07:00
Greg Magolan
c4f6fcff42
fix: add missing convienence aliases to exclude_srcs_packages
2022-07-29 18:52:54 -07:00
Greg Magolan
01da4db80c
fix: add missing convienence aliases to include_srcs_packages
2022-07-29 18:52:54 -07:00
Greg Magolan
6d3c1a393b
chore: add improved error messages to copy_to_directory when include_srcs_packages and include_srcs_patterns are empty
2022-07-29 18:52:54 -07:00
Greg Magolan
71910e93f3
feat: add include_srcs_packages and exclude_srcs_packages and improve implementation and documentation of other filters and transformations ( #203 )
2022-07-29 16:16:33 -07:00
Greg Magolan
83912625a3
chore: fix out-of-date text in copy_to_directory.include_srcs_patterns docstring ( #202 )
2022-07-28 23:31:08 -07:00
Greg Magolan
c74f0e29a6
chore: fix out-of-date text in copy_to_directory.include_srcs_patterns docstring: ( #201 )
2022-07-28 23:13:22 -07:00
Greg Magolan
a5e61b3961
fix: dedup additional files in copy_to_directory_action ( #200 )
2022-07-28 20:39:12 -07:00
Greg Magolan
e4399557d7
chore: add '?' pattern to test cases of copy_to_directory ( #199 )
2022-07-28 12:59:30 -07:00
Greg Magolan
85e8b7e555
feat: add glob support to copy_to_directory include_srcs_patterns, exclude_srcs_patterns, replace_prefixes and root_paths. ( #196 )
...
This deprecates exclude_prefixes with docs suggesting to using exclude_srcs_patterns instead
2022-07-28 12:50:41 -07:00
Greg Magolan
a945d66eb5
chore: add glob_match to docs ( #195 )
2022-07-28 11:15:14 -07:00
Greg Magolan
fd03cf0ecb
feat: add glob_match starlark utility function that support "*", "**" and "?" expressions as well as optionally allow for "*" and "?" to match of path separators ( #194 )
2022-07-27 18:48:02 -07:00
Greg Magolan
61c7cc209b
feat: add include_prefixes to copy_to_directory ( #193 )
2022-07-27 15:15:42 -07:00
Derek Cormier
998ee22369
fix: improve error message in directory_path when directory does not ( #192 )
...
exist
2022-07-22 09:37:27 -07:00
Derek Cormier
d0a897488b
fix: patch diff_test with runfiles fix
2022-07-15 13:07:28 -07:00
Alex Eagle
8a11a106db
chore: change default for run_binary#stamp
...
Greg convinced me that users will get really slow stamped builds because most run_binary tools don't actually read the status files, but will be cache-invalidated.
2022-07-15 09:29:28 -07:00
Alex Eagle
56bc408d94
feat: add stamping ability to run_binary
...
Fixes #185
2022-07-14 22:37:42 -07:00
Alex Eagle
de081fb72e
feat: basic stamping support
2022-07-14 22:37:42 -07:00
Alex Eagle
6f52c77a51
assert that directories aren't included in file_exists
2022-07-14 07:53:05 -07:00
Alex Eagle
546758589d
Add utility for checking file existence.
...
Avoids continued copy-paste of this like https://github.com/aspect-build/rules_ts/blob/main/ts/defs.bzl#L35-L44
2022-07-14 07:53:05 -07:00
Jesse Schalken
f2e5f4675f
fix: diff_test not working for files in directories starting with "external"
...
Example "external-dependencies/foo.txt"
2022-07-07 16:31:00 -07:00
Derek Cormier
a24508a202
fix: remote target_compatible_with from jq and yq toolchains
2022-07-06 10:46:23 -07:00
Derek Cormier
77474915d8
docs: encourage use of latest yq/jq in docs
2022-07-02 10:00:23 -07:00
Greg Magolan
d4f6524fbd
feat: add copy_to_directory_action
2022-06-28 09:08:45 -07:00
Alex Eagle
910786038c
chore: improve error when run_binary has no outputs
...
Otherwise users get
```
Traceback (most recent call last):
File "/private/var/tmp/_bazel_long.ho/a2216e06a77a9425f6dcd5fd195f64d5/external/aspect_bazel_lib/lib/private/run_binary.bzl", line 46, column 20, in _impl
ctx.actions.run(
Error in run: param 'outputs' may not be empty
```
2022-06-27 12:30:13 -07:00
David
f08952a8a6
docs: add a note about excluding from linters/formatters ( #156 )
2022-06-24 12:30:08 -07:00
Derek Cormier
de6e9ef843
fix: improve copy_to_bin error messaging when file is in external repo
2022-06-22 10:43:16 -07:00