Matt
59453e5c50
fix: Set size to a default value as well as timeout. ( #839 )
...
* fix: Set size to a default value as well as timeout.
Currently, we are unable to run our `write_source_files` tests in our pre-upload checks, because we have `--test_size_filter=small`, and setting `size` will attempt to set it on both the run rule and the test rule, the former being invalid.
* code review feedback
* chore: fix one more test that should use size for defaulting
---------
Co-authored-by: Alex Eagle <alex@aspect.dev>
2024-07-19 12:50:50 -07:00
Josh Giles
3c0dbd5895
fix: Directory hidden files in write_source_file. ( #860 )
...
* Fix #667 : Dir hidden files in write_source_file.
Copy and manage hidden files starting with "." in write_source_files.
Previously these files were not supported if they were in the top level
of the directory to copy.
* Add test and fix error messages from cp, chmod.
* Also fix executable dir case.
* Fix issue with copying directory rather than contents.
2024-06-11 00:30:53 -07:00
Greg Magolan
1baf14f65c
chore: add example of using write_source_file to merge output tree artifact files with source files that are already in an output directory ( #730 )
2024-01-22 21:03:31 -08:00
Greg Magolan
5b3b7d7794
feat: allow write_source_file(s) to write source files to bazel packages outside of the target's package ( #717 )
2024-01-10 15:07:03 -08:00
Alex Eagle
e00ea2b977
chore: update pre-commit buildifier ( #563 )
...
It needs to match the one CI runs in
https://github.com/aspect-build/bazel-lib/actions/runs/6357283303/job/17268197322
2023-09-29 14:42:33 -07:00
Matt Mackay
8fa2127518
fix: allow for BUILD files in outputs of write_source_file ( #540 )
2023-09-21 19:50:04 -04:00
Matt Mackay
62394fbb68
fix: lookup source files from execroot when running diff_test on RBE ( #531 )
2023-09-21 13:27:08 -07:00
Greg Magolan
fde705ba8c
feat: make bazel-lib the source-of-truth for Aspect recommended bazelrc settings ( #369 )
2023-02-16 16:59:21 -08:00
Greg Magolan
35b7662e55
fix: write_source_files should use target platform for additional_update_targets ( #297 )
2022-12-03 15:02:33 -08:00
Greg Magolan
9059f8fa5e
feat: add executable attribute to write_source_files
2022-12-03 10:46:08 -08:00
Alex Eagle
a9dc052c8b
feat: add assert_outputs
...
It's a simple way to make an executable example demonstrate what outputs a rule produces.
See https://github.com/aspect-build/rules_ts/pull/214 for an example usage in the real world.
2022-10-31 15:25:12 -07:00
Jason Bedard
475015bee0
refactor: give internal impl methods meaningful names ( #252 )
2022-09-20 15:23:56 -07:00
Alex Eagle
896ee0c1f0
chore: set test timeouts to short
...
I recently enabled --test_verbose_timeout_warnings and that caused a bunch of warnings in our build.
This fixes it, and adds a utility for us or others to make test-wrapping macros that set to short by default.
2022-08-20 13:58:43 -07:00
Alex Eagle
15ec78eb73
ci: enable engflow RBE for github actions
2022-08-19 08:42:00 -07:00
Derek Cormier
3ff61c57e9
fix: fix a bug where write_source_files diff_test fails on windows when
...
a source is from an external repository
2022-06-16 09:10:30 -07:00
Greg Magolan
9a9a1888e1
chore: normalize @generated by comments ( #93 )
2022-04-29 00:49:15 -07:00
Greg Magolan
f1e10df09c
chore: replace is_windows select pattern with target_platform_has_constraint pattern ( #95 )
2022-04-29 00:36:51 -07:00
Derek Cormier
e0af9633ed
chore: fix buildifier errors
2022-04-15 15:44:40 -07:00
Jason Bedard
0f30bf96b7
fix(write_source_files): fix nested directories ( #65 )
2022-04-06 11:25:17 -07:00
Greg Magolan
3599515632
fix: ensure out_file does not show up in source file query of write_source_file so that it can be used with ibazel ( #52 )
2022-03-28 14:53:58 -07:00
Greg Magolan
bda5c632be
feat: replace default_info_files with output_files which adds output_group attribute ( #50 )
2022-03-15 17:36:22 -07:00
Greg Magolan
3b93ee0baa
Add DefaultOutputPathInfo provider and update write_source_files to accept it ( #48 )
...
Also update write_source_files to accept DirectoryPathInfo
2022-03-14 17:33:52 -07:00
Derek Cormier
f788d286d0
feat: write to source folders ( #41 )
2022-03-02 12:58:36 -08:00
Derek Cormier
71c1b893d6
feat: bulk updates for write_source_files ( #40 )
2022-02-28 15:42:20 -08:00
Derek Cormier
2195e1c69a
feat: write_source_files windows implementation
2022-02-24 16:45:31 -08:00
Derek Cormier
8e6a15ceae
feat: write_source_files
2022-02-07 10:00:35 -08:00
