bazel/bazel-lib
2
0
Fork 0
mirror of https://github.com/bazel-contrib/bazel-lib synced 2024-11-26 13:30:30 +00:00
Code Issues Releases Activity

chore: make it possible to override run_binary#use_default_shell_env (#762)

Browse source 
Still not documented as public API. We think this leads to non-hermeticity and could cause cache misses, so it must be used with care.

Part of https://github.com/aspect-build/rules_js/issues/1303
This commit is contained in:
Alex Eagle 2024-02-21 13:37:47 -08:00 committed by Greg Magolan
parent 4db4fb1192
commit c215c623f4
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/private/run_binary.bzl
View file

@ -76,7 +76,7 @@ Possible fixes:
mnemonic = ctx.attr.mnemonic if ctx.attr.mnemonic else None, mnemonic = ctx.attr.mnemonic if ctx.attr.mnemonic else None,
progress_message = ctx.attr.progress_message if ctx.attr.progress_message else None, progress_message = ctx.attr.progress_message if ctx.attr.progress_message else None,
execution_requirements = ctx.attr.execution_requirements if ctx.attr.execution_requirements else None, execution_requirements = ctx.attr.execution_requirements if ctx.attr.execution_requirements else None,
use_default_shell_env = False, use_default_shell_env = ctx.attr.use_default_shell_env,
env = dicts.add(ctx.configuration.default_shell_env, envs), env = dicts.add(ctx.configuration.default_shell_env, envs),
input_manifests = tool_input_mfs, input_manifests = tool_input_mfs,
) )
@ -104,6 +104,7 @@ _run_binary = rule(
"mnemonic": attr.string(), "mnemonic": attr.string(),
"progress_message": attr.string(), "progress_message": attr.string(),
"execution_requirements": attr.string_dict(), "execution_requirements": attr.string_dict(),
"use_default_shell_env": attr.bool(),
}, **STAMP_ATTRS), }, **STAMP_ATTRS),
) )

3
lib/tests/run_binary_expansions/BUILD.bazel
View file

@ -53,6 +53,9 @@ run_binary(
}, },
progress_message = "doing some work to make %{output}", progress_message = "doing some work to make %{output}",
tool = ":expansions_sh", tool = ":expansions_sh",
# May introduce non-determinism; use with care!
# See e.g. https://github.com/bazelbuild/bazel/issues/4912
use_default_shell_env = True,
) )
diff_test( diff_test(