From adca27740972bb1314669d05126ec3fdde656b45 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Wed, 12 Apr 2023 09:46:06 -0700 Subject: [PATCH] fix: use test command for test flags I don't think there's any reason we apply these two flags for `build`? --- .aspect/bazelrc/ci.bazelrc | 4 ++-- lib/tests/bazelrc_presets/all/ci.bazelrc | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.aspect/bazelrc/ci.bazelrc b/.aspect/bazelrc/ci.bazelrc index b8abe75..4d91ee0 100644 --- a/.aspect/bazelrc/ci.bazelrc +++ b/.aspect/bazelrc/ci.bazelrc @@ -3,7 +3,7 @@ # or split up into multiple test targets with sharding or manually. # Set this flag to exclude targets that have their timeout set to eternal (>15m) from running on CI. # Docs: https://bazel.build/docs/user-manual#test-timeout-filters -build --test_timeout_filters=-eternal +test --test_timeout_filters=-eternal # Set this flag to enable re-tries of failed tests on CI. # When any test target fails, try one or more times. This applies regardless of whether the "flaky" @@ -16,7 +16,7 @@ build --test_timeout_filters=-eternal # is more likely to get fixed. # Note that when passing after the first attempt, Bazel will give a special "FLAKY" status. # Docs: https://bazel.build/docs/user-manual#flaky-test-attempts -build --flaky_test_attempts=2 +test --flaky_test_attempts=2 # Announce all announces command options read from the bazelrc file(s) when starting up at the # beginning of each Bazel invocation. This is very useful on CI to be able to inspect what Bazel rc diff --git a/lib/tests/bazelrc_presets/all/ci.bazelrc b/lib/tests/bazelrc_presets/all/ci.bazelrc index b8abe75..4d91ee0 100644 --- a/lib/tests/bazelrc_presets/all/ci.bazelrc +++ b/lib/tests/bazelrc_presets/all/ci.bazelrc @@ -3,7 +3,7 @@ # or split up into multiple test targets with sharding or manually. # Set this flag to exclude targets that have their timeout set to eternal (>15m) from running on CI. # Docs: https://bazel.build/docs/user-manual#test-timeout-filters -build --test_timeout_filters=-eternal +test --test_timeout_filters=-eternal # Set this flag to enable re-tries of failed tests on CI. # When any test target fails, try one or more times. This applies regardless of whether the "flaky" @@ -16,7 +16,7 @@ build --test_timeout_filters=-eternal # is more likely to get fixed. # Note that when passing after the first attempt, Bazel will give a special "FLAKY" status. # Docs: https://bazel.build/docs/user-manual#flaky-test-attempts -build --flaky_test_attempts=2 +test --flaky_test_attempts=2 # Announce all announces command options read from the bazelrc file(s) when starting up at the # beginning of each Bazel invocation. This is very useful on CI to be able to inspect what Bazel rc