From 91eeca7d40e22a9f96671444f792fa3bb2545d96 Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Thu, 23 Feb 2023 00:28:46 -0800 Subject: [PATCH] fix: remove --experimental_guard_against_concurrent_changes from recommended correctness settings (#380) --- .aspect/bazelrc/ci.bazelrc | 4 ++-- .aspect/bazelrc/correctness.bazelrc | 5 ----- e2e/bzlmod/.aspect/bazelrc/correctness.bazelrc | 5 ----- .../.aspect/bazelrc/correctness.bazelrc | 5 ----- e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc | 5 ----- e2e/workspace/.aspect/bazelrc/correctness.bazelrc | 5 ----- lib/tests/bazelrc_presets/all/ci.bazelrc | 4 ++-- lib/tests/bazelrc_presets/all/correctness.bazelrc | 5 ----- 8 files changed, 4 insertions(+), 34 deletions(-) diff --git a/.aspect/bazelrc/ci.bazelrc b/.aspect/bazelrc/ci.bazelrc index 38ff2b3..5c17b99 100644 --- a/.aspect/bazelrc/ci.bazelrc +++ b/.aspect/bazelrc/ci.bazelrc @@ -33,11 +33,11 @@ build --show_timestamps # https://bazel.build/reference/command-line-reference#flag--show_progress_rate_limit build --show_progress_rate_limit=5 -# Don't use cursor controls in its screen output. +# Use cursor controls in screen output. # Docs: https://bazel.build/docs/user-manual#curses build --curses=yes -# Use colors to highlight its output on the screen. Set to `no` if your CI does not display colors. +# Use colors to highlight output on the screen. Set to `no` if your CI does not display colors. # Docs: https://bazel.build/docs/user-manual#color build --color=yes diff --git a/.aspect/bazelrc/correctness.bazelrc b/.aspect/bazelrc/correctness.bazelrc index 84b51c2..d9ef2e5 100644 --- a/.aspect/bazelrc/correctness.bazelrc +++ b/.aspect/bazelrc/correctness.bazelrc @@ -54,11 +54,6 @@ build --experimental_allow_tags_propagation fetch --experimental_allow_tags_propagation query --experimental_allow_tags_propagation -# Checking the ctime of input files of an action before uploading it to a remote cache. Prevents -# concurrent local file modification from poisoning the build cache. -# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_guard_against_concurrent_changes -build --experimental_guard_against_concurrent_changes - # Do not automatically create `__init__.py` files in the runfiles of Python targets. Fixes the wrong # default that comes from Google's internal monorepo by using `__init__.py` to delimit a Python # package. Precisely, when a `py_binary` or `py_test` target has `legacy_create_init` set to `auto (the diff --git a/e2e/bzlmod/.aspect/bazelrc/correctness.bazelrc b/e2e/bzlmod/.aspect/bazelrc/correctness.bazelrc index 84b51c2..d9ef2e5 100644 --- a/e2e/bzlmod/.aspect/bazelrc/correctness.bazelrc +++ b/e2e/bzlmod/.aspect/bazelrc/correctness.bazelrc @@ -54,11 +54,6 @@ build --experimental_allow_tags_propagation fetch --experimental_allow_tags_propagation query --experimental_allow_tags_propagation -# Checking the ctime of input files of an action before uploading it to a remote cache. Prevents -# concurrent local file modification from poisoning the build cache. -# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_guard_against_concurrent_changes -build --experimental_guard_against_concurrent_changes - # Do not automatically create `__init__.py` files in the runfiles of Python targets. Fixes the wrong # default that comes from Google's internal monorepo by using `__init__.py` to delimit a Python # package. Precisely, when a `py_binary` or `py_test` target has `legacy_create_init` set to `auto (the diff --git a/e2e/bzlmod_write_source_files_external/.aspect/bazelrc/correctness.bazelrc b/e2e/bzlmod_write_source_files_external/.aspect/bazelrc/correctness.bazelrc index 84b51c2..d9ef2e5 100644 --- a/e2e/bzlmod_write_source_files_external/.aspect/bazelrc/correctness.bazelrc +++ b/e2e/bzlmod_write_source_files_external/.aspect/bazelrc/correctness.bazelrc @@ -54,11 +54,6 @@ build --experimental_allow_tags_propagation fetch --experimental_allow_tags_propagation query --experimental_allow_tags_propagation -# Checking the ctime of input files of an action before uploading it to a remote cache. Prevents -# concurrent local file modification from poisoning the build cache. -# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_guard_against_concurrent_changes -build --experimental_guard_against_concurrent_changes - # Do not automatically create `__init__.py` files in the runfiles of Python targets. Fixes the wrong # default that comes from Google's internal monorepo by using `__init__.py` to delimit a Python # package. Precisely, when a `py_binary` or `py_test` target has `legacy_create_init` set to `auto (the diff --git a/e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc b/e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc index 84b51c2..d9ef2e5 100644 --- a/e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc +++ b/e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc @@ -54,11 +54,6 @@ build --experimental_allow_tags_propagation fetch --experimental_allow_tags_propagation query --experimental_allow_tags_propagation -# Checking the ctime of input files of an action before uploading it to a remote cache. Prevents -# concurrent local file modification from poisoning the build cache. -# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_guard_against_concurrent_changes -build --experimental_guard_against_concurrent_changes - # Do not automatically create `__init__.py` files in the runfiles of Python targets. Fixes the wrong # default that comes from Google's internal monorepo by using `__init__.py` to delimit a Python # package. Precisely, when a `py_binary` or `py_test` target has `legacy_create_init` set to `auto (the diff --git a/e2e/workspace/.aspect/bazelrc/correctness.bazelrc b/e2e/workspace/.aspect/bazelrc/correctness.bazelrc index 84b51c2..d9ef2e5 100644 --- a/e2e/workspace/.aspect/bazelrc/correctness.bazelrc +++ b/e2e/workspace/.aspect/bazelrc/correctness.bazelrc @@ -54,11 +54,6 @@ build --experimental_allow_tags_propagation fetch --experimental_allow_tags_propagation query --experimental_allow_tags_propagation -# Checking the ctime of input files of an action before uploading it to a remote cache. Prevents -# concurrent local file modification from poisoning the build cache. -# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_guard_against_concurrent_changes -build --experimental_guard_against_concurrent_changes - # Do not automatically create `__init__.py` files in the runfiles of Python targets. Fixes the wrong # default that comes from Google's internal monorepo by using `__init__.py` to delimit a Python # package. Precisely, when a `py_binary` or `py_test` target has `legacy_create_init` set to `auto (the diff --git a/lib/tests/bazelrc_presets/all/ci.bazelrc b/lib/tests/bazelrc_presets/all/ci.bazelrc index 38ff2b3..5c17b99 100644 --- a/lib/tests/bazelrc_presets/all/ci.bazelrc +++ b/lib/tests/bazelrc_presets/all/ci.bazelrc @@ -33,11 +33,11 @@ build --show_timestamps # https://bazel.build/reference/command-line-reference#flag--show_progress_rate_limit build --show_progress_rate_limit=5 -# Don't use cursor controls in its screen output. +# Use cursor controls in screen output. # Docs: https://bazel.build/docs/user-manual#curses build --curses=yes -# Use colors to highlight its output on the screen. Set to `no` if your CI does not display colors. +# Use colors to highlight output on the screen. Set to `no` if your CI does not display colors. # Docs: https://bazel.build/docs/user-manual#color build --color=yes diff --git a/lib/tests/bazelrc_presets/all/correctness.bazelrc b/lib/tests/bazelrc_presets/all/correctness.bazelrc index 84b51c2..d9ef2e5 100644 --- a/lib/tests/bazelrc_presets/all/correctness.bazelrc +++ b/lib/tests/bazelrc_presets/all/correctness.bazelrc @@ -54,11 +54,6 @@ build --experimental_allow_tags_propagation fetch --experimental_allow_tags_propagation query --experimental_allow_tags_propagation -# Checking the ctime of input files of an action before uploading it to a remote cache. Prevents -# concurrent local file modification from poisoning the build cache. -# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_guard_against_concurrent_changes -build --experimental_guard_against_concurrent_changes - # Do not automatically create `__init__.py` files in the runfiles of Python targets. Fixes the wrong # default that comes from Google's internal monorepo by using `__init__.py` to delimit a Python # package. Precisely, when a `py_binary` or `py_test` target has `legacy_create_init` set to `auto (the