From 7d901b7d9b36ae11ae1c03005a61f3caa246f0eb Mon Sep 17 00:00:00 2001 From: ajwerner Date: Tue, 8 Oct 2024 14:35:51 -0400 Subject: [PATCH] fix(bazelrc): move flag to bazel6.bazelrc (#959) This flag became a no-op in Bazel 7 (see [here][0]) and then was removed in Bazel 8 (see [here][1]). Fixes #958 [0]: https://github.com/bazelbuild/bazel/commit/c88f374246c0a7b3a87c58553d3b9ad0ef4e9ad4 [1]: https://github.com/bazelbuild/bazel/commit/17ee62e91d86eb6e9d4f9d29e6f8cc0dc2a87acd --- .aspect/bazelrc/bazel6.bazelrc | 8 ++++++++ .aspect/bazelrc/performance.bazelrc | 6 ------ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.aspect/bazelrc/bazel6.bazelrc b/.aspect/bazelrc/bazel6.bazelrc index 2da4343..545cc1c 100644 --- a/.aspect/bazelrc/bazel6.bazelrc +++ b/.aspect/bazelrc/bazel6.bazelrc @@ -25,3 +25,11 @@ build --noexperimental_action_cache_store_output_metadata build --noexperimental_check_output_files fetch --noexperimental_check_output_files query --noexperimental_check_output_files + +# Don't apply `--noremote_upload_local_results` and `--noremote_accept_cached` to the disk cache. +# If you have both `--noremote_upload_local_results` and `--disk_cache`, then this fixes a bug where +# Bazel doesn't write to the local disk cache as it treats as a remote cache. +# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_remote_results_ignore_disk +# NB: This flag is in bazel6.bazelrc because it became a no-op in Bazel 7 and has been removed +# in Bazel 8. +build --incompatible_remote_results_ignore_disk diff --git a/.aspect/bazelrc/performance.bazelrc b/.aspect/bazelrc/performance.bazelrc index 8026102..fc404c2 100644 --- a/.aspect/bazelrc/performance.bazelrc +++ b/.aspect/bazelrc/performance.bazelrc @@ -1,9 +1,3 @@ -# Don't apply `--noremote_upload_local_results` and `--noremote_accept_cached` to the disk cache. -# If you have both `--noremote_upload_local_results` and `--disk_cache`, then this fixes a bug where -# Bazel doesn't write to the local disk cache as it treats as a remote cache. -# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_remote_results_ignore_disk -build --incompatible_remote_results_ignore_disk - # Directories used by sandboxed non-worker execution may be reused to avoid unnecessary setup costs. # Save time on Sandbox creation and deletion when many of the same kind of action run during the # build.