From 385717a2a53e6a6b5ab55f0ba1f0991659b1ed5f Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Wed, 14 Aug 2024 10:41:50 -0700 Subject: [PATCH] chore: turn off bzlmod misguided warning (#901) * chore: turn off bzlmod misguided warning These are misinformed, the module resolver should be permitted to find an MVS solution * chore: update golden --- .aspect/bazelrc/bazel7.bazelrc | 10 +++++++--- lib/tests/bazelrc_presets/all/bazel7.bazelrc | 10 +++++++--- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/.aspect/bazelrc/bazel7.bazelrc b/.aspect/bazelrc/bazel7.bazelrc index 212c26e..dbd40ee 100644 --- a/.aspect/bazelrc/bazel7.bazelrc +++ b/.aspect/bazelrc/bazel7.bazelrc @@ -1,8 +1,12 @@ # Speed up all builds by not checking if external repository files have been modified. # Docs: https://github.com/bazelbuild/bazel/blob/1af61b21df99edc2fc66939cdf14449c2661f873/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java#L244 -build --noexperimental_check_external_repository_files -fetch --noexperimental_check_external_repository_files -query --noexperimental_check_external_repository_files +common --noexperimental_check_external_repository_files + +# Don't report when the root module's lower bound for a dependency happens to be less than the resolved version. +# This is expected and should NOT prompt an engineer to update our lower bound to match. +# WARNING: For repository 'aspect_bazel_lib', the root module requires module version aspect_bazel_lib@1.30.2, +# but got aspect_bazel_lib@1.31.2 in the resolved dependency graph. +common --check_direct_dependencies=off # Directories used by sandboxed non-worker execution may be reused to avoid unnecessary setup costs. # Save time on Sandbox creation and deletion when many of the same kind of action run during the diff --git a/lib/tests/bazelrc_presets/all/bazel7.bazelrc b/lib/tests/bazelrc_presets/all/bazel7.bazelrc index 212c26e..dbd40ee 100644 --- a/lib/tests/bazelrc_presets/all/bazel7.bazelrc +++ b/lib/tests/bazelrc_presets/all/bazel7.bazelrc @@ -1,8 +1,12 @@ # Speed up all builds by not checking if external repository files have been modified. # Docs: https://github.com/bazelbuild/bazel/blob/1af61b21df99edc2fc66939cdf14449c2661f873/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java#L244 -build --noexperimental_check_external_repository_files -fetch --noexperimental_check_external_repository_files -query --noexperimental_check_external_repository_files +common --noexperimental_check_external_repository_files + +# Don't report when the root module's lower bound for a dependency happens to be less than the resolved version. +# This is expected and should NOT prompt an engineer to update our lower bound to match. +# WARNING: For repository 'aspect_bazel_lib', the root module requires module version aspect_bazel_lib@1.30.2, +# but got aspect_bazel_lib@1.31.2 in the resolved dependency graph. +common --check_direct_dependencies=off # Directories used by sandboxed non-worker execution may be reused to avoid unnecessary setup costs. # Save time on Sandbox creation and deletion when many of the same kind of action run during the