feat: add copy_directory_action help to the public API (#67)

docs/copy_directory.md

@@ -31,8 +31,33 @@ for more context.
 | Name  | Description | Default Value |
 | :------------- | :------------- | :------------- |
 | <a id="copy_directory-name"></a>name |  Name of the rule.   |  none |
-| <a id="copy_directory-src"></a>src |  A Label. The directory to make a copy of. (Can also be the label of a rule that generates a directory.)   |  none |
+| <a id="copy_directory-src"></a>src |  The directory to make a copy of. Can be a source directory or TreeArtifact.   |  none |
 | <a id="copy_directory-out"></a>out |  Path of the output directory, relative to this package.   |  none |
 | <a id="copy_directory-kwargs"></a>kwargs |  further keyword arguments, e.g. <code>visibility</code>   |  none |
 
 
+<a id="#copy_directory_action"></a>
+
+## copy_directory_action
+
+<pre>
+copy_directory_action(<a href="#copy_directory_action-ctx">ctx</a>, <a href="#copy_directory_action-src">src</a>, <a href="#copy_directory_action-dst">dst</a>, <a href="#copy_directory_action-is_windows">is_windows</a>)
+</pre>
+
+Helper function that creates an action to copy a directory from src to dst.
+
+This helper is used by copy_directory. It is exposed as a public API so it can be used within
+other rule implementations.
+
+
+**PARAMETERS**
+
+
+| Name  | Description | Default Value |
+| :------------- | :------------- | :------------- |
+| <a id="copy_directory_action-ctx"></a>ctx |  The rule context.   |  none |
+| <a id="copy_directory_action-src"></a>src |  The directory to make a copy of. Can be a source directory or TreeArtifact.   |  none |
+| <a id="copy_directory_action-dst"></a>dst |  The directory to copy to. Must be a TreeArtifact.   |  none |
+| <a id="copy_directory_action-is_windows"></a>is_windows |  If true, an cmd.exe action is created so there is no bash dependency.   |  <code>False</code> |
+
+

lib/copy_directory.bzl

@@ -7,6 +7,8 @@ on Windows (no Bash is required).
 load(
     "//lib/private:copy_directory.bzl",
     _copy_directory = "copy_directory",
+    _copy_helper = "copy_directory_action",
 )
 
 copy_directory = _copy_directory
+copy_directory_action = _copy_helper

lib/private/copy_directory.bzl

@@ -14,7 +14,7 @@ _execution_requirements = {
 }
 
 # buildifier: disable=function-docstring
-def copy_cmd(ctx, src_dir, src_path, dst):
+def _copy_cmd(ctx, src, dst):
     # Most Windows binaries built with MSVC use a certain argument quoting
     # scheme. Bazel uses that scheme too to quote arguments. However,
     # cmd.exe uses different semantics, so Bazel's quoting is wrong here.
@@ -22,27 +22,27 @@ def copy_cmd(ctx, src_dir, src_path, dst):
     # quoting or escaping is required.
     # Put a hash of the file name into the name of the generated batch file to
     # make it unique within the package, so that users can define multiple copy_file's.
-    bat = ctx.actions.declare_file("%s-%s-cmd.bat" % (ctx.label.name, hash(src_path)))
+    bat = ctx.actions.declare_file("%s-%s-cmd.bat" % (ctx.label.name, hash(src.path)))
 
     # Flags are documented at
     # https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/robocopy
     # NB: robocopy return non-zero exit codes on success so we must exit 0 after calling it
     cmd_tmpl = "@robocopy \"{src}\" \"{dst}\" /E >NUL & @exit 0"
     mnemonic = "CopyDirectory"
-    progress_message = "Copying directory %s" % src_path
+    progress_message = "Copying directory %s" % src.path
 
     ctx.actions.write(
         output = bat,
         # Do not use lib/shell.bzl's shell.quote() method, because that uses
         # Bash quoting syntax, which is different from cmd.exe's syntax.
         content = cmd_tmpl.format(
-            src = src_path.replace("/", "\\"),
+            src = src.path.replace("/", "\\"),
             dst = dst.path.replace("/", "\\"),
         ),
         is_executable = True,
     )
     ctx.actions.run(
-        inputs = [src_dir],
+        inputs = [src],
         tools = [bat],
         outputs = [dst],
         executable = "cmd.exe",
@@ -54,33 +54,49 @@ def copy_cmd(ctx, src_dir, src_path, dst):
     )
 
 # buildifier: disable=function-docstring
-def copy_bash(ctx, src_dir, src_path, dst):
+def _copy_bash(ctx, src, dst):
-    cmd_tmpl = "rm -rf \"$2\" && cp -fR \"$1/\" \"$2\""
+    cmd = "rm -rf \"$2\" && cp -fR \"$1/\" \"$2\""
     mnemonic = "CopyDirectory"
-    progress_message = "Copying directory %s" % src_path
+    progress_message = "Copying directory %s" % src.path
 
     ctx.actions.run_shell(
-        tools = [src_dir],
+        tools = [src],
         outputs = [dst],
-        command = cmd_tmpl,
+        command = cmd,
-        arguments = [src_path, dst.path],
+        arguments = [src.path, dst.path],
         mnemonic = mnemonic,
         progress_message = progress_message,
         use_default_shell_env = True,
         execution_requirements = _execution_requirements,
     )
 
-def _copy_directory_impl(ctx):
+def copy_directory_action(ctx, src, dst, is_windows = False):
-    output = ctx.actions.declare_directory(ctx.attr.out)
+    """Helper function that creates an action to copy a directory from src to dst.
-    src_dir = ctx.file.src
-    src_path = src_dir.path
-    if ctx.attr.is_windows:
-        copy_cmd(ctx, src_dir, src_path, output)
-    else:
-        copy_bash(ctx, src_dir, src_path, output)
 
-    files = depset(direct = [output])
+    This helper is used by copy_directory. It is exposed as a public API so it can be used within
-    runfiles = ctx.runfiles(files = [output])
+    other rule implementations.
+
+    Args:
+        ctx: The rule context.
+        src: The directory to make a copy of. Can be a source directory or TreeArtifact.
+        dst: The directory to copy to. Must be a TreeArtifact.
+        is_windows: If true, an cmd.exe action is created so there is no bash dependency.
+    """
+    if not src.is_source and not dst.is_directory:
+        fail("src must be a source directory or TreeArtifact")
+    if dst.is_source or not dst.is_directory:
+        fail("dst must be a TreeArtifact")
+    if is_windows:
+        _copy_cmd(ctx, src, dst)
+    else:
+        _copy_bash(ctx, src, dst)
+
+def _copy_directory_impl(ctx):
+    dst = ctx.actions.declare_directory(ctx.attr.out)
+    copy_directory_action(ctx, ctx.file.src, dst, ctx.attr.is_windows)
+
+    files = depset(direct = [dst])
+    runfiles = ctx.runfiles(files = [dst])
 
     return [DefaultInfo(files = files, runfiles = runfiles)]
 
@@ -109,8 +125,7 @@ def copy_directory(name, src, out, **kwargs):
 
     Args:
       name: Name of the rule.
-      src: A Label. The directory to make a copy of.
+      src: The directory to make a copy of. Can be a source directory or TreeArtifact.
-          (Can also be the label of a rule that generates a directory.)
       out: Path of the output directory, relative to this package.
       **kwargs: further keyword arguments, e.g. `visibility`
     """