From 270a1bd9e373621d1bffe82256ac1dd64c497718 Mon Sep 17 00:00:00 2001 From: Sahin Yort Date: Wed, 20 Sep 2023 15:57:29 -0700 Subject: [PATCH] fix: check in generated bazelrcs (#535) --- .../.aspect/bazelrc/correctness.bazelrc | 6 ++++++ e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc | 6 ++++++ e2e/coreutils/.aspect/bazelrc/correctness.bazelrc | 6 ++++++ 3 files changed, 18 insertions(+) diff --git a/e2e/bzlmod_write_source_files_external/.aspect/bazelrc/correctness.bazelrc b/e2e/bzlmod_write_source_files_external/.aspect/bazelrc/correctness.bazelrc index 56fad5f..a540eb8 100644 --- a/e2e/bzlmod_write_source_files_external/.aspect/bazelrc/correctness.bazelrc +++ b/e2e/bzlmod_write_source_files_external/.aspect/bazelrc/correctness.bazelrc @@ -60,3 +60,9 @@ query --experimental_allow_tags_propagation # https://github.com/bazelbuild/bazel/issues/10076. # Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_default_to_explicit_init_py build --incompatible_default_to_explicit_init_py + +# Set default value of `allow_empty` to `False` in `glob()`. This prevents a common mistake when +# attempting to use `glob()` to match files in a subdirectory that is opaque to the current package +# because it contains a BUILD file. See https://github.com/bazelbuild/bazel/issues/8195. +# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_disallow_empty_glob +common --incompatible_disallow_empty_glob diff --git a/e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc b/e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc index 56fad5f..a540eb8 100644 --- a/e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc +++ b/e2e/copy_to_directory/.aspect/bazelrc/correctness.bazelrc @@ -60,3 +60,9 @@ query --experimental_allow_tags_propagation # https://github.com/bazelbuild/bazel/issues/10076. # Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_default_to_explicit_init_py build --incompatible_default_to_explicit_init_py + +# Set default value of `allow_empty` to `False` in `glob()`. This prevents a common mistake when +# attempting to use `glob()` to match files in a subdirectory that is opaque to the current package +# because it contains a BUILD file. See https://github.com/bazelbuild/bazel/issues/8195. +# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_disallow_empty_glob +common --incompatible_disallow_empty_glob diff --git a/e2e/coreutils/.aspect/bazelrc/correctness.bazelrc b/e2e/coreutils/.aspect/bazelrc/correctness.bazelrc index 56fad5f..a540eb8 100644 --- a/e2e/coreutils/.aspect/bazelrc/correctness.bazelrc +++ b/e2e/coreutils/.aspect/bazelrc/correctness.bazelrc @@ -60,3 +60,9 @@ query --experimental_allow_tags_propagation # https://github.com/bazelbuild/bazel/issues/10076. # Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_default_to_explicit_init_py build --incompatible_default_to_explicit_init_py + +# Set default value of `allow_empty` to `False` in `glob()`. This prevents a common mistake when +# attempting to use `glob()` to match files in a subdirectory that is opaque to the current package +# because it contains a BUILD file. See https://github.com/bazelbuild/bazel/issues/8195. +# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_disallow_empty_glob +common --incompatible_disallow_empty_glob