From 251b1d07db1bb61d5cfdf81c8e615b8054ad0b7f Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Fri, 16 Feb 2024 13:56:38 -0800 Subject: [PATCH] presets: remove eternal test_timeout_filtering (#758) In practice we've disabled this setting at some clients, because there's not a surrounding workflow to find these targets are being silently dropped from CI, nor run them on another schedule. We can re-introduce something better when we add Test Selection to Aspect Workflows. --- .aspect/bazelrc/ci.bazelrc | 7 ------- lib/tests/bazelrc_presets/all/ci.bazelrc | 7 ------- 2 files changed, 14 deletions(-) diff --git a/.aspect/bazelrc/ci.bazelrc b/.aspect/bazelrc/ci.bazelrc index 4d91ee0..11aae33 100644 --- a/.aspect/bazelrc/ci.bazelrc +++ b/.aspect/bazelrc/ci.bazelrc @@ -1,10 +1,3 @@ -# We recommend enforcing a policy that keeps your CI from being slowed down -# by individual test targets that should be optimized -# or split up into multiple test targets with sharding or manually. -# Set this flag to exclude targets that have their timeout set to eternal (>15m) from running on CI. -# Docs: https://bazel.build/docs/user-manual#test-timeout-filters -test --test_timeout_filters=-eternal - # Set this flag to enable re-tries of failed tests on CI. # When any test target fails, try one or more times. This applies regardless of whether the "flaky" # tag appears on the target definition. diff --git a/lib/tests/bazelrc_presets/all/ci.bazelrc b/lib/tests/bazelrc_presets/all/ci.bazelrc index 4d91ee0..11aae33 100644 --- a/lib/tests/bazelrc_presets/all/ci.bazelrc +++ b/lib/tests/bazelrc_presets/all/ci.bazelrc @@ -1,10 +1,3 @@ -# We recommend enforcing a policy that keeps your CI from being slowed down -# by individual test targets that should be optimized -# or split up into multiple test targets with sharding or manually. -# Set this flag to exclude targets that have their timeout set to eternal (>15m) from running on CI. -# Docs: https://bazel.build/docs/user-manual#test-timeout-filters -test --test_timeout_filters=-eternal - # Set this flag to enable re-tries of failed tests on CI. # When any test target fails, try one or more times. This applies regardless of whether the "flaky" # tag appears on the target definition.