fix: allow copy_to_directory to have an empty srcs list (#871)

This commit is contained in:
Greg Magolan 2024-06-21 10:33:00 -07:00 committed by GitHub
parent 3330c38904
commit 18ae5a89a6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 19 additions and 3 deletions

View File

@ -461,9 +461,6 @@ def copy_to_directory_bin_action(
})
file_inputs.append(f.file)
if not file_inputs:
fail("No files to copy")
config = {
"allow_overwrites": allow_overwrites,
"dst": dst.path,

View File

@ -449,3 +449,22 @@ diff_test(
file1 = "case_21",
file2 = ":expected_21",
)
# Case 22: empty sources creates an empty directory output
copy_to_directory(
name = "case_22",
srcs = [],
)
copy_to_directory(
name = "expected_22",
srcs = ["dir_expected_22"],
exclude_srcs_patterns = ["**/filter_me_out"],
)
diff_test(
name = "case_22_test",
file1 = "case_22",
file2 = ":expected_22",
tags = ["local"], # seems that the Bazel sandbox has trouble with empty directories
)